Fix for Newline issue #1462
Merged
Fix for Newline issue #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishkk
approved these changes
Mar 6, 2018
| @@ -254,7 +254,7 @@ public void GetTestPlatformExtensionsShouldIncludeOutputDirectoryExtensionsIfTes | |||
| // Verify | |||
| List<string> expectedList = new List<string> { @"C:\Source2\ext1.TestAdapter.dll", @"C:\Source1\ext2.TestAdapter.dll" }; | |||
| CollectionAssert.AreEqual(expectedList, resultExtensions); | |||
| this.mockMessageLogger.Verify(ml => ml.SendMessage(TestMessageLevel.Warning, "Multiple versions of same extension found. Selecting the highest version.\n ext1.TestAdapter : 2.2\n ext2.TestAdapter : 5.5"), Times.Once); | |||
| this.mockMessageLogger.Verify(ml => ml.SendMessage(TestMessageLevel.Warning, "Multiple versions of same extension found. Selecting the highest version." + Environment.NewLine + " ext1.TestAdapter : 2.2\n ext2.TestAdapter : 5.5"), Times.Once); | |||
| @@ -11,6 +11,7 @@ namespace Microsoft.VisualStudio.TestPlatform.CommandLine.UnitTests.Processors | |||
| using System.Linq; | |||
| using Microsoft.VisualStudio.TestPlatform.Common; | |||
| using Moq; | |||
| using System; | |||
| @@ -6,6 +6,7 @@ namespace Microsoft.VisualStudio.TestPlatform.CommandLine.UnitTests.Processors | |||
| using Microsoft.VisualStudio.TestPlatform.CommandLine.Processors; | |||
| using Microsoft.VisualStudio.TestPlatform.Common.Utilities; | |||
| using Microsoft.VisualStudio.TestTools.UnitTesting; | |||
| using System; | |||
| @@ -9,6 +9,7 @@ namespace Microsoft.VisualStudio.TestPlatform.CommandLine.UnitTests.Processors | |||
| using Microsoft.VisualStudio.TestPlatform.Common.Utilities; | |||
|
|
|||
| using ExceptionUtilities = Microsoft.VisualStudio.TestPlatform.CommandLine.UnitTests.ExceptionUtilities; | |||
| using System; | |||
| @@ -8,6 +8,7 @@ namespace Microsoft.VisualStudio.TestPlatform.CommandLine.UnitTests.Processors | |||
| using vstest.console.UnitTests.Processors; | |||
| using Microsoft.VisualStudio.TestPlatform.Common.Utilities; | |||
| using ExceptionUtilities = Microsoft.VisualStudio.TestPlatform.CommandLine.UnitTests.ExceptionUtilities; | |||
| using System; | |||
singhsarab
added a commit
to singhsarab/vstest
that referenced
this pull request
Mar 6, 2018
singhsarab
added a commit
that referenced
this pull request
Mar 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dotnet build behaviour has changed. The latest dotnet build the resources in such a manner that newline is represented by "\r\n" instead of "\n".
Fixing the tests for string comparison issue.