Fixed the normal verbosity level to not log the full information for non-failed tests #1396
Conversation
…ollectors usage along with an embedded testsetting
…ailed tests. Normal level willnot log the full information for non-failed tests
| @@ -334,7 +394,7 @@ public void TestResultHandlerShouldWriteToConsoleShouldShowPassedTestsForNormalV | |||
| } | |||
|
|
|||
| [TestMethod] | |||
| public void TestResultHandlerShouldShowStdOutMsgOfPassedTestIfVerbosityIsNormal() | |||
| public void TestResultHandlerShouldShowNotStdOutMsgOfPassedTestIfVerbosityIsNormal() | |||
There was a problem hiding this comment.
TestResultHandlerShouldShowNotStdOutMsgOfPassedTestIfVerbosityIsNormal [](start = 20, length = 70)
Nit: ShouldNotShow
please change the name for test following this one as well.
| @@ -142,9 +142,9 @@ public void Initialize(TestLoggerEvents events, string testRunDirectory) | |||
| } | |||
|
|
|||
| // Register for the events. | |||
| events.TestRunMessage += this.TestMessageHandler; | |||
There was a problem hiding this comment.
We have been following this convention to use 'this' with members, makes it readable, any specific reason why we are removing it ?
| @@ -337,7 +337,6 @@ private void TestMessageHandler(object sender, TestRunMessageEventArgs e) | |||
| Output.Warning(ConsoleLogger.AppendPrefix, e.Message); | |||
| break; | |||
| case TestMessageLevel.Error: | |||
| this.testOutcome = TestOutcome.Failed; | |||
There was a problem hiding this comment.
Why this is removed? This impact behavior. If the adapter/platform send any error message after this change we not failing test run.
There was a problem hiding this comment.
Will fix this and add an UT. Currently didn't see any UT fail.. Also why is the failure of a run decided at a logger level ?
| break; | ||
| } | ||
|
|
||
| var output = string.Format(CultureInfo.CurrentCulture, CommandLineResources.PassedTestIndicator, testDisplayName); |
There was a problem hiding this comment.
On Minimal level the passed test name should not get displayed. Update the test to catch this scenario.
| @@ -453,16 +481,16 @@ private void TestRunCompleteHandler(object sender, TestRunCompleteEventArgs e) | |||
| { | |||
| Output.Error(false, CommandLineResources.TestRunAborted); | |||
| } | |||
| else if (this.testOutcome == TestOutcome.Failed && this.testsTotal > 0) | |||
| else if (testsFailed > 0) | |||
There was a problem hiding this comment.
testsFailed [](start = 21, length = 11)
We should revert this one.
We could have a passing tests and then we some failure occurred.
TestOutcome is set to failed in case some error occurs during the run, it is not necessary that we would have failing test.
There was a problem hiding this comment.
Ok. Will fix this. Didnt see any UT failing though.. will add one.
| @@ -61,7 +61,8 @@ internal enum Verbosity | |||
| { | |||
| Quiet, | |||
| Minimal, | |||
| Normal | |||
| Normal, | |||
| Detailed | |||
There was a problem hiding this comment.
Add detailed to help for customer to aware this option.
Description
Updated the normal verbosity behavior to not output the detailed information for a test other than failed test. Added a detailed verbosity option to do the same