-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for coded UI test debug broken #1352
Conversation
@@ -22,7 +26,7 @@ | |||
</ItemGroup> | |||
<ItemGroup> | |||
<PackageReference Include="Microsoft.Internal.TestPlatform.Extensions"> | |||
<Version>15.6.0-preview-1202328</Version> | |||
<Version>$(TestPlatformExternalsVersion)</Version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
scripts/build.ps1
Outdated
@@ -433,16 +433,17 @@ function Create-VsixPackage | |||
$testImpactComComponentsDir = Join-Path $extensionsPackageDir "TestImpact" | |||
$legacyTestImpactComComponentsDir = Join-Path $extensionsPackageDir "V1\TestImpact" | |||
|
|||
$testPlatformExternalsVersion = "15.6.0-preview-1251113" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[xml](Get-Content $TP_ROOT_DIR\scripts\build\TestPlatform.Dependencies.props).Project.PropertyGroup.TestPlatformExternalsVersion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I was searching for this 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to investigate that, rather than acquiring dependencies from nuget, & inserting it back, we create a vsix in devdiv, which directly drop these dependencies into Testplatform\Externals, just like we didf for UWP recently?
@mayankbansal018 I had discussed same with @codito. We thought that will cause different versions of external assemblies(MSTestv1 adapter, etc) ships in Microsoft.Testplatform nuget package and VS. |
@smadala, I agree there could be different bits in VS preview, & TP nuget preview bits, but we can make sure that same version ends up in non-preview bits of Testplatform nugets, & in official VS release. Which should be acceptable. It also avoids us making insertions in VS, just to update some dependencies, & we also need to go through the check-points, which we can avoid. I think it's worth it. |
In my opinion, we shouldn't fragment the distribution with more packages. While we get to do less VS insertions, but the cost of validation ( I'd rather fix the issues with VS insertion process if there are any, or plan the insertions better. |
Related issue
Can't debug coded UI test in latest VS2017