Highest version filtering for extensions. #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…found. Keep only the highest versioned extensions.
navin22
reviewed
Sep 8, 2017
| { | ||
| Dictionary<string, Tuple<Version, string>> extensionMap = new Dictionary<string, Tuple<Version, string>>(); | ||
|
|
||
| foreach (var extensionFullPath in extensions) |
There was a problem hiding this comment.
foreach (var extensionFullPath in extensions) [](start = 12, length = 45)
Please try group by, and then get the highest file version within the group if the group size > 1
codito
approved these changes
Sep 8, 2017
| @@ -70,6 +73,13 @@ public FileAttributes GetFileAttributes(string path) | |||
| } | |||
|
|
|||
| /// <inheritdoc/> | |||
| public Version GetFileVersion(string path) | |||
| { | |||
| var currentFileVersion = FileVersionInfo.GetVersionInfo(path)?.FileVersion; | |||
There was a problem hiding this comment.
nit: null check not required
| public Version GetFileVersion(string path) | ||
| { | ||
| var currentFileVersion = FileVersionInfo.GetVersionInfo(path)?.FileVersion; | ||
| return Version.TryParse(currentFileVersion, out var currentVersion) ? currentVersion : DefaultFileVersion; |
There was a problem hiding this comment.
May not work in UAP. We should move to PlatformAbstraction otherwise.
| /// <returns>Filtered list of extensions</returns> | ||
| private IEnumerable<string> FilterExtensionsBasedOnVersion(IEnumerable<string> extensions) | ||
| { | ||
| var filteredExtensions = new List<string>(); |
|
|
||
| var extensionGroups = extensions.GroupBy(ext => Path.GetFileNameWithoutExtension(ext)); | ||
|
|
||
| foreach (var extensionGroup in extensionGroups) |
| [TestMethod] | ||
| public void GetTestPlatformExtensionsShouldReturnPathToSingleFileExtensionOfATypeIfVersionsAreSame() | ||
| { | ||
| List<string> sourcesDir = new List<string> { "C:\\Source1", "C:\\Source2" }; |
smadala
approved these changes
Sep 11, 2017
| { | ||
| if (extensionGroup.Count() > 1) | ||
| { | ||
| var maxFile = extensionGroup.OrderByDescending(a => this.fileHelper.GetFileVersion(a)).First(); |
| private Version GetAndLogFileVersion(string path) | ||
| { | ||
| var fileVersion = this.fileHelper.GetFileVersion(path); | ||
| EqtTrace.Verbose("FileVersion for {0} : {1}", path, fileVersion); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for filtering in case multiple extensions with same name are found. Keep only the highest versioned extensions.
Pending: Unit tests.