You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The space between Pro and 2016 was a bit jarring on the cmd line. I tried executing more cli/test/dotnet-migrate.Tests/TestResults/_MacBook-Pro 2016-11-24 02:16:53.trx and this failed because I didn't quote the path and it contained a space.
This seems quite unnatural on OS X. I think that OS and its apps tend to avoid spaces in paths.
The text was updated successfully, but these errors were encountered:
+1. This will be a behavior difference from previous versions of mstest or vstest.console, I don't think users will mind it though. @pvlakshm thoughts?
* Replace whilespace with underscore in the name of trx file.
Issue: #244
Validation:
1)Added unit test to cover changes.
2) Manually validated on linux and windows machine
* Address PR comment
* Renamed TestableTrxLogger.
The .trx file written for CLI tests gets written to a path like:
.../cli/test/dotnet-migrate.Tests/TestResults/_MacBook-Pro 2016-11-24 02:16:53.trx
The space between
Pro
and2016
was a bit jarring on the cmd line. I tried executingmore cli/test/dotnet-migrate.Tests/TestResults/_MacBook-Pro 2016-11-24 02:16:53.trx
and this failed because I didn't quote the path and it contained a space.This seems quite unnatural on OS X. I think that OS and its apps tend to avoid spaces in paths.
The text was updated successfully, but these errors were encountered: