Skip to content

SCMRepository lifecycle is weird #293813

@bpasero

Description

@bpasero

While finding leaks using Copilot I came across SCMRepository and how it gets passed in a DisposableStore:

private readonly disposables: DisposableStore,

Which it then later disposes itself:

this.disposables.dispose();

I think this is a bit against our rules for object lifecycle, rather I would have expected the SCMRepository to manage its own disposables and be a IDisposable.

Metadata

Metadata

Assignees

Labels

debtCode quality issues

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions