-
Notifications
You must be signed in to change notification settings - Fork 37.8k
Open
Labels
debtCode quality issuesCode quality issues
Description
While finding leaks using Copilot I came across SCMRepository and how it gets passed in a DisposableStore:
| private readonly disposables: DisposableStore, |
Which it then later disposes itself:
| this.disposables.dispose(); |
I think this is a bit against our rules for object lifecycle, rather I would have expected the SCMRepository to manage its own disposables and be a IDisposable.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
debtCode quality issuesCode quality issues