Get debug settings from user preference and send it to debuggee #135

andxu · 2017-11-07T09:31:47Z

No description provided.

2. get debug settings from user settings and send it to debuggee

testforstephen · 2017-11-07T10:03:40Z

src/configurationProvider.ts

@@ -217,6 +223,57 @@ function configLogLevel(level) {
    return commands.executeJavaLanguageServerCommand(commands.JAVA_CONFIG_LOG_LEVEL, convertLogLevel(level));
 }

+interface IDebugSettings {
+    show_hex?: boolean;


Use Camel to keep name convention consistent.

testforstephen · 2017-11-08T01:16:29Z

src/configurationProvider.ts

+
+function collectDebugSettings(): IDebugSettings {
+    const settings: IDebugSettings = {};
+    if (vscode.workspace.getConfiguration().get("java.debug.settings.showHex")) {


Cannot set the value to false. no need to if.

testforstephen · 2017-11-08T02:07:41Z

package.json

+        },
+        "java.debug.settings.showHex": {
+          "type": "boolean",
+          "default": false


add description here.

akaroml · 2017-11-09T02:39:18Z

README.md

@@ -69,6 +69,10 @@ Please also check the documentation of [Language Support for Java by Red Hat](ht
 ### User Settings

 - `java.debug.logLevel`: minimum level of debugger logs that are sent to VS Code, defaults to `warn`.
+- `java.debug.settings.showHex`: whether or not the number should be displayed as hex format in variable view, defaults to `false`.


show integers in hex format

akaroml · 2017-11-09T02:40:10Z

README.md

@@ -69,6 +69,10 @@ Please also check the documentation of [Language Support for Java by Red Hat](ht
 ### User Settings

 - `java.debug.logLevel`: minimum level of debugger logs that are sent to VS Code, defaults to `warn`.
+- `java.debug.settings.showHex`: whether or not the number should be displayed as hex format in variable view, defaults to `false`.
+- `java.debug.settings.showStaticVariables`: whether or not the static variables will be displayed in variable view, defaults to `true`.


show static variables in "Variables" viewlet

akaroml · 2017-11-09T02:41:03Z

README.md

@@ -69,6 +69,10 @@ Please also check the documentation of [Language Support for Java by Red Hat](ht
 ### User Settings

 - `java.debug.logLevel`: minimum level of debugger logs that are sent to VS Code, defaults to `warn`.
+- `java.debug.settings.showHex`: whether or not the number should be displayed as hex format in variable view, defaults to `false`.
+- `java.debug.settings.showStaticVariables`: whether or not the static variables will be displayed in variable view, defaults to `true`.
+- `java.debug.settings.showQualifiedNames`: whether or not the class name should be displayed using the fully qualified class name, defaults to `false`.


show fully qualified class names

akaroml · 2017-11-09T02:42:51Z

package.json

+        },
+        "java.debug.settings.showHex": {
+          "type": "boolean",
+          "description" : "whether or not the number should be displayed as hex format in variable view",


Please change the descriptions accordingly.

Same for below ones.

akaroml · 2017-11-09T04:17:13Z

README.md

@@ -69,6 +69,10 @@ Please also check the documentation of [Language Support for Java by Red Hat](ht
 ### User Settings

 - `java.debug.logLevel`: minimum level of debugger logs that are sent to VS Code, defaults to `warn`.
+- `java.debug.settings.showHex`: show the number in hex format in variable view, defaults to `false`.


show numbers in hex format in "Variables" viewlet, de...

akaroml · 2017-11-09T04:17:34Z

README.md

@@ -69,6 +69,10 @@ Please also check the documentation of [Language Support for Java by Red Hat](ht
 ### User Settings

 - `java.debug.logLevel`: minimum level of debugger logs that are sent to VS Code, defaults to `warn`.
+- `java.debug.settings.showHex`: show the number in hex format in variable view, defaults to `false`.
+- `java.debug.settings.showStaticVariables`: show the static variables in variable view, defaults to `true`.
+- `java.debug.settings.showQualifiedNames`: show the fully qualified class name in variable view, defaults to `false`.


class names.

akaroml · 2017-11-09T05:50:35Z

README.md

@@ -69,6 +69,10 @@ Please also check the documentation of [Language Support for Java by Red Hat](ht
 ### User Settings

 - `java.debug.logLevel`: minimum level of debugger logs that are sent to VS Code, defaults to `warn`.
+- `java.debug.settings.showHex`: show numbers in hex format in "Variables" viewlet, defaults to `false`.
+- `java.debug.settings.showStaticVariables`: show static variables in "Variables" viewlet, defaults to `true`.
+- `java.debug.settings.showQualifiedNames`: show the fully qualified class names in "Variables" viewlet, defaults to `false`.


remove "the" before fully....

andxu added 2 commits November 7, 2017 17:29

1. watch user settings for changed event, apply it when change happens

d6388a7

2. get debug settings from user settings and send it to debuggee

Merge remote-tracking branch 'origin/master'

21a4ebd

testforstephen reviewed Nov 7, 2017

View reviewed changes

change settings names

8e9424b

testforstephen reviewed Nov 8, 2017

View reviewed changes

package.json Outdated

},

"java.debug.settings.showHex": {

"type": "boolean",

"default": false

Copy link

Contributor

testforstephen Nov 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add description here.

andxu added 2 commits November 8, 2017 11:08

merge log level to other settings.

be00676

update desc to debug settings.

23fbf51

testforstephen previously approved these changes Nov 8, 2017

View reviewed changes

akaroml requested changes Nov 9, 2017

View reviewed changes

update description for better clause

a85108f

andxu dismissed testforstephen’s stale review via a85108f November 9, 2017 03:08

akaroml requested changes Nov 9, 2017

View reviewed changes

andxu added 2 commits November 9, 2017 13:23

update description for better clause

3bc362f

fix typo

e244a15

akaroml previously approved these changes Nov 9, 2017

View reviewed changes

update description for better clause

81db55c

andxu dismissed akaroml’s stale review via 81db55c November 9, 2017 05:53

akaroml approved these changes Nov 9, 2017

View reviewed changes

andxu merged commit 96f2b7c into master Nov 9, 2017

andxu deleted the andy_user_settings2 branch November 9, 2017 06:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Get debug settings from user preference and send it to debuggee #135

Get debug settings from user preference and send it to debuggee #135

Uh oh!

andxu commented Nov 7, 2017

Uh oh!

testforstephen Nov 7, 2017

Uh oh!

testforstephen Nov 8, 2017

Uh oh!

testforstephen Nov 8, 2017

Uh oh!

akaroml Nov 9, 2017

Uh oh!

akaroml Nov 9, 2017

Uh oh!

akaroml Nov 9, 2017

Uh oh!

akaroml Nov 9, 2017

Uh oh!

akaroml Nov 9, 2017

Uh oh!

akaroml Nov 9, 2017

Uh oh!

akaroml Nov 9, 2017

Uh oh!

akaroml Nov 9, 2017

Uh oh!

Uh oh!

Get debug settings from user preference and send it to debuggee #135

Get debug settings from user preference and send it to debuggee #135

Uh oh!

Conversation

andxu commented Nov 7, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!