This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
set GOPATH for debug adaptor automatically #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
ramya-rao-a
suggested changes
Apr 2, 2017
src/goMain.ts
Outdated
| @@ -196,6 +196,14 @@ export function activate(ctx: vscode.ExtensionContext): void { | |||
| 'program': '${file}' | |||
| }); | |||
| } | |||
|
|
|||
| if (!config.env || !config.env['GOPATH']) { | |||
| let binpath = getBinPath('dlv'); | |||
There was a problem hiding this comment.
have you tried config.env['GOPATH'] = process.env['GOPATH'] ?
|
@esjeon Good catch in finding the bug I have updated your branch with a simpler way of getting the GOPATH. Will merge the PR as soon as the tests are green |
ramya-rao-a
approved these changes
Apr 3, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch modifies
go.debug.startSessioncommand to add environment variable 'GOPATH' to launch configuration JSON object. A properGOPATHis searched usinggetBinPath, which utilizes VSCode settings.This allows more versatile configuration and provides better out-of-box experience.