This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Honor the 'cwd' launch configuration argument #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ankon, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
|
Testing done: "Launch extension", then open the workspace that contains the go file from the issue, debug it, and verify that the output is what we expected. I'm not sure how to write an automated test for this, and would need help (or at least some pointers) for that. |
mattetti
approved these changes
Jan 10, 2017
There was a problem hiding this comment.
As per the delve code base:
RootCommand.PersistentFlags().StringVar(&WorkingDir, "wd", ".", "Working directory for running the program.")https://github.com/derekparker/delve/blob/master/cmd/dlv/cmds/commands.go
LGTM
mattetti
added a commit
to mattetti/vscode-go
that referenced
this pull request
Jan 16, 2017
…ild-i * 'master' of github.com:Microsoft/vscode-go: Moved debugging doc to a separate wiki Make a copy of process.env when setting VSCODE_GOTOOLS Debugger cannot read settings Improve error handling of test coverage (microsoft#721) Use proper plurality in output (microsoft#720) Fixes microsoft#303 Dont run test if current file is not test file Added a note on how to debug single tests Allow Go tools to be installed in a separate GOPATH (microsoft#351) Fix typo in README.md (microsoft#715) Honor the 'cwd' launch configuration argument (microsoft#714)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #710