This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Fixes #592 Use go from GOROOT while installing tools #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw1nk
reviewed
Nov 1, 2016
| @@ -110,7 +110,8 @@ function installTools(goVersion: SemVersion, missing?: string[]) { | |||
|
|
|||
| missing.reduce((res: Promise<string[]>, tool: string) => { | |||
| return res.then(sofar => new Promise<string[]>((resolve, reject) => { | |||
| cp.exec('go get -u -v ' + tools[tool], { env: process.env }, (err, stdout, stderr) => { | |||
| let goRuntimePath = getGoRuntimePath(); | |||
There was a problem hiding this comment.
You would probably only need to lookup the goRuntimePath once during the install phase so to improve performance move it above the reduce function.
ramya-rao-a
force-pushed
the
use-goroot
branch
from
eff1684
to
28d44e7
Compare
roblourens
approved these changes
Nov 1, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been using Go from GOROOT (falling back to PATH if not found) everywhere while running the
gocommand except while installing tools.This PR will fix that
Fixes #592