Dont generate unit tests for non Go files #584

ramya-rao-a · 2016-10-30T00:42:30Z

Fixes #563

roblourens

I also noticed that gotests won't generate tests if the test files already exist, and it will write a message to stdout saying that. But vscode-go will still show the success message. Maybe can just show gotests's output in the future.

roblourens · 2016-10-31T21:42:31Z

src/goGenerateTests.ts

+		return;
+	}
+	if (!editor.document.fileName.endsWith('.go')) {
+		vscode.window.showInformationMessage('Cannot generate unit tests. File in the editor is not a Go file.');


Is there definitely no case where a go file can have some other extension?

@roblourens Not that I know of

Yeah I searched around and couldn't find any

ramya-rao-a · 2016-10-31T22:00:21Z

@roblourens #566 is tracking your #584 (review)

Dont generate unit tests for non Go files

25fd902

msftclas added the cla-not-required label Oct 30, 2016

roblourens approved these changes Oct 31, 2016

View reviewed changes

ramya-rao-a merged commit 2df9204 into microsoft:master Oct 31, 2016

ramya-rao-a deleted the generateTestsUpdate branch April 9, 2017 16:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dont generate unit tests for non Go files #584

Dont generate unit tests for non Go files #584

ramya-rao-a commented Oct 30, 2016

roblourens left a comment

roblourens Oct 31, 2016

ramya-rao-a Oct 31, 2016

roblourens Oct 31, 2016

ramya-rao-a commented Oct 31, 2016

Dont generate unit tests for non Go files #584

Dont generate unit tests for non Go files #584

Conversation

ramya-rao-a commented Oct 30, 2016

roblourens left a comment

Choose a reason for hiding this comment

roblourens Oct 31, 2016

Choose a reason for hiding this comment

ramya-rao-a Oct 31, 2016

Choose a reason for hiding this comment

roblourens Oct 31, 2016

Choose a reason for hiding this comment

ramya-rao-a commented Oct 31, 2016