Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Add workspace resolution for -vettool in go.vetFlags #2528

Merged
merged 1 commit into from
May 24, 2019
Merged

Add workspace resolution for -vettool in go.vetFlags #2528

merged 1 commit into from
May 24, 2019

Conversation

tamayika
Copy link
Contributor

Closes #2527

This PR add ${workspaceRoot}, ${workspaceFolder} and ~(except Windows) resolution for -vettool= or --vettool= in go.vetFlags.

How to confirm

I've prepared sample analyzer repository(https://github.com/tamayika/analyzer).

  1. Clone https://github.com/tamayika/analyzer
  2. Build it
  3. Launch vscode-go in debug mode and open github.com/tamayika/analyzer
  4. See go vet result(if you can not see, edit go file and save it.)

Sample image:
dev

@msftclas
Copy link

msftclas commented May 22, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

ramya-rao-a
ramya-rao-a approved these changes May 24, 2019
View reviewed changes
Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is your first PR contribution to this project, Thanks & Welcome!

@ramya-rao-a ramya-rao-a merged commit 9cf61c4 into microsoft:master May 24, 2019
@tamayika tamayika deleted the vettool-workspace-root-support branch May 24, 2019 10:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ramya-rao-a ramya-rao-a ramya-rao-a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

go.vetFlags does not support ${workspaceRoot}
3 participants
@tamayika @msftclas @ramya-rao-a