This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
fix: #1026 remove go 1.5 support #2319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
suggested changes
Feb 22, 2019
| if (tool === 'golint') { | ||
| vscode.window.showInformationMessage('golint no longer supports go1.8, update your settings to use gometalinter as go.lintTool and install gometalinter'); | ||
| return; | ||
| } | ||
| if (tool === 'gotests') { | ||
| vscode.window.showInformationMessage('Generate unit tests feature is not supported as gotests tool needs go1.6 or higher.'); | ||
| vscode.window.showInformationMessage('Generate unit tests feature is not supported as gotests tool needs go1.9 or higher.'); |
There was a problem hiding this comment.
Has gotests really stopped supported versions below 1.9?
test/go.test.ts
Outdated
| @@ -24,6 +24,7 @@ import { getAllPackages } from '../src/goPackages'; | |||
| import { getImportPath } from '../src/util'; | |||
| import { goPlay } from '../src/goPlayground'; | |||
| import { runFillStruct } from '../src/goFillStruct'; | |||
| import { version } from 'punycode'; | |||
There was a problem hiding this comment.
Why do we need this import?
ramya-rao-a
approved these changes
Mar 2, 2019
|
Thanks @oneslash |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.