This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
chg: user provided flag handling when running tests #1976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
approved these changes
Oct 10, 2018
There was a problem hiding this comment.
@rschmied, I see that this is your first contribution to vscode-go. Welcome & Thanks!
I hope that you have registered both for the Microsoft Hacktoberfest and the one from Digitalocean
Happy Coding!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is regarding #1534
The patch re-orders the user-provided flags and appends them at the end before passing to
go test. This way, flags using-xargsdo not interfere with the defaults flags.An example is the use of a flag consumed by glog
-v=4which would interfere with the-vof thego testcommand. The glog flag has to be passed via-xargsbefore the-vcontrolling the verbosity of the test output.