This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Use col numbers from cmd outputs to give src locations for error/warnings #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dhowden This feature is now available in the latest update (0.6.78) to the Go extension. Thanks for the PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors/warnings parsed from compiler output now include column numbers in source locations.
Both source annotations and "Problems" use the column data.
Starts #1572.
Later improvements could include trying to extract further information so that annotations can be isolated to the problematic tokens instead of marking the whole line after the location column.
Probably needs testing on pre-go1.9 when the column information was not provided in compiler output.