Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

(go modules) gotype-live doesn't recognize imports in go modules #1950

Closed
tamasfe opened this issue Sep 29, 2018 · 10 comments
Closed

(go modules) gotype-live doesn't recognize imports in go modules #1950

tamasfe opened this issue Sep 29, 2018 · 10 comments
Labels
go-modules Related to Go modules upstream

Comments

@tamasfe
Copy link

tamasfe commented Sep 29, 2018

I'm posting the issue here because the gotype-live repo hasn't been touched for 2 years, and I don't know any other application that depends on it.

I would be more than happy to fix it, but it's beyond my knowledge at the moment. I believe the fix should be trivial for someone who knows his/her way around go compiling and package/module resolution though.

I'm using the latest beta of the extension.

repro steps:
Create a module outside GOPATH as usual, and enable live errors.

@ramya-rao-a
Copy link
Contributor

Thanks for reporting @tamasf97

I've logged tylerstillwater/gotype-live#3 to track this issue upstream.

@tylerb

Would you have some time to look into this?
This tool is being tracked in golang/go#24661 as well. So, folks from the Go tool team would be able to help if you have any questions working with modules.

@ramya-rao-a ramya-rao-a added upstream go-modules Related to Go modules labels Sep 30, 2018
@tylerstillwater
Copy link
Contributor

I'll take a look, but I doubt I can do much at this point. gotype-live is effectively a fork of gotype with the ability to pass in the data for a working file via stdin. As such, I probably need to wait for gotype to be updated to work with go modules, then merge those changes into my fork.

@ramya-rao-a
Copy link
Contributor

@tylerb Understood.

On a side note, can you resolve tylerstillwater/gotype-live#1?

@tylerstillwater
Copy link
Contributor

Whoops! Not sure how that slipped by me. I resolved it.

@chespinoza
Copy link

Hi, are there some news about this issue? Thanks.

@tylerstillwater
Copy link
Contributor

As it stands now, I'd say this feature/functionality is going to be/has been made obsolete by the new gopls language server system. @ramya-rao-a thoughts?

@ramya-rao-a
Copy link
Contributor

That is true. When the diagnostics feature of the new language server gopls is enabled, it provides diagnostics on type.

Module users are suggested to use the language server already.

Can somebody here try the latest beta version of this extension. Here, the diagnostics feature of the language server will be used by default and the gotype-live tool will only be used in non-module and non language server scenarios

@naysolange
Copy link

I've installed gopls and still I have a non-recognized import. Any ideas?

@ramya-rao-a
Copy link
Contributor

@nportas Your case seem to be unrelated to the issue at hand here. Please log a new issue with screenshots of the problem along with your Go related settings

@ramya-rao-a
Copy link
Contributor

In the latest update (0.11.0) to the Go extension, gotypes-live will not be invoked when using Go modules or when using the diagnostics feature from the language feature

@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
go-modules Related to Go modules upstream
Projects
None yet
Development

No branches or pull requests

5 participants