Fix paths to xlftool to make it work with VS 15.4 #301
Conversation
| @@ -29,23 +29,23 @@ | |||
| <CreateItem Include="@(ResxResources)" AdditionalMetadata="Language=%(ResxLang.Identity)"> | |||
| <Output ItemName="LocResourceFile" TaskParameter="Include"/> | |||
| </CreateItem> | |||
| <Exec Command="$(TestFxPackagesRoot)fmdev.xlftool\0.1.3\tools\xlftool.exe update -Resx %(LocResourceFile.Identity) -Xlf $(ResourceDirectory)\xlf\%(LocResourceFile.Filename).%(LocResourceFile.Language).xlf" /> | |||
| <Exec Command="$(TestFxPackagesRoot)fmdev.xlftool\0.1.3\tools\xlftool.exe update -Resx %(ResxResources.Identity) -Xlf $(ResourceDirectory)\xlf\%(ResxResources.Filename).xlf" /> | |||
| <Exec Command="$(TestFxPackagesRoot)fmdev.xlftool.0.1.3\tools\xlftool.exe update -Resx %(LocResourceFile.Identity) -Xlf $(ResourceDirectory)\xlf\%(LocResourceFile.Filename).%(LocResourceFile.Language).xlf" /> | |||
There was a problem hiding this comment.
I see both fmdev.xlftool and fmdev.xlftool.0.1.3 paths in packages directory. Could this be a nuget change (may be newer version)?
56 $ ls D:\dd\gh\Microsoft\testfx\packages\fmdev*
Directory: D:\dd\gh\Microsoft\testfx\packages
Mode LastWriteTime Length Name
---- ------------- ------ ----
d----- 6/12/2017 5:01 PM fmdev.xlftool
d----- 6/12/2017 5:01 PM fmdev.xlftool.0.1.3There was a problem hiding this comment.
On my PC only single folder generated
PS > ls packages\fmdev*
Каталог: D:\d\user\GitHub\testfx\packages
Mode LastWriteTime Length Name
---- ------------- ------ ----
d----- 10/30/2017 1:36 PM fmdev.xlftool.0.1.3
- Add missing Microsoft.Internal.TestPlatform.ObjectModel - Fix path to make it work with latest NuGet Related work items: microsoft#300
|
@kant2002 : Thank you for your Pull Request. |
| @@ -2,5 +2,6 @@ | |||
| <packages> | |||
| <package id="Castle.Core" version="4.0.0" targetFramework="net452" /> | |||
| <package id="Moq" version="4.7.8" targetFramework="net452" /> | |||
| <package id="Microsoft.Internal.TestPlatform.ObjectModel" version="14.0.0" targetFramework="net452" /> | |||
There was a problem hiding this comment.
We can take only this change though.
There was a problem hiding this comment.
I make only this change on the #310. I still want to find a way how it will work on my PC and without potential problems for you CI setup. If there any hints what bad could happens on CI, I maybe could change something.
There was a problem hiding this comment.
We are still trying to investigate this. We will get back to you once we figure his out. We will keep this PR open to track this issue. Meanwhile, will push in the other PR.
Since I don't closely monitor changes in the NuGet behavior I could not say is this a settled fix, or it will not cover all cases and both ways should be supported.
Without that change I receive errors when run
Build.cmd