-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove explicit boxing and unboxing #84
Conversation
@JamieMagee - thanks for the suggestion. We need to add a few more test cases for casting. We'll revisit this PR once they've been added. |
Hello @JamieMagee , could you please restore your branch if possible? so we can reopen this PR. It was deleted unintendedly. |
@v-xiangs Sure, I've restored it now. |
@JamieMagee Thank you very much for the quick response. |
a4d7f1d
to
fa7f5a1
Compare
I've updated the branch to resolve any merge conflicts. |
Codecov Report
@@ Coverage Diff @@
## dev #84 +/- ##
============================================
+ Coverage 40.16% 41.44% +1.28%
- Complexity 1892 1983 +91
============================================
Files 107 107
Lines 24482 24669 +187
Branches 4038 4102 +64
============================================
+ Hits 9833 10224 +391
+ Misses 12815 12554 -261
- Partials 1834 1891 +57
Continue to review full report at Codecov.
|
@JamieMagee Thank you for your hard works ! |
Hi @JamieMagee, thanks for the contribution! A couple of suggestions:
Other than those 2, the changes look good. |
Formatting changes
Change the formatting to previous version without the auto formatting
@peterbae Thanks for the feedback. I've been a little busy, most recently with oneweek, but I'll make the changes as soon as I have some time. |
@JamieMagee Thanks for the reply. We wanted to include this in our next release so I've made the small formatting changes to one file. I will merge this PR after the tests have passed. |
Test results are good. Merging in. |
@peterbae Thanks for all your help with getting this PR merged 👍 |
Explicit boxing and unboxing in unnecessary since Java 5. See https://docs.oracle.com/javase/tutorial/java/data/autoboxing.html
This also fixes #13