Fix the project's build errors in JDK 9/10 #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
andxu
previously approved these changes
May 23, 2018
akaroml
previously approved these changes
May 23, 2018
yaohaizh
reviewed
May 23, 2018
| <profile> | ||
| <id>default-tools.jar</id> | ||
| <activation> | ||
| <jdk>(,9)</jdk> |
There was a problem hiding this comment.
9 is not official supported by Oracle. Just start with 10 is okay.
There was a problem hiding this comment.
It represents the range < 9
yaohaizh
previously approved these changes
May 23, 2018
yaohaizh
reviewed
May 23, 2018
| * This fix is only for the JDI implementation by JDK. Other JDI implementations (such as JDT) doesn't have the impact. | ||
| */ | ||
| for (LaunchingConnector con : connectors) { | ||
| if (con.getClass().getName().equals("com.sun.tools.jdi.SunCommandLineLauncher")) { |
There was a problem hiding this comment.
Make the string final static value as the other values.
There was a problem hiding this comment.
Nice. Fixed.
testforstephen
dismissed stale reviews from yaohaizh, akaroml, and andxu
via
8612e74
yaohaizh
approved these changes
May 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jinbo Wang jinbwan@microsoft.com
Fix the issue #145.