Skip to content

Make getSuggestion APIs internal. #25520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2018
Merged

Make getSuggestion APIs internal. #25520

merged 1 commit into from
Jul 10, 2018

Conversation

@DanielRosenwasser
Copy link
Member

Fixes #25519.

@DanielRosenwasser
Copy link
Member Author

FWIW, searching GitHub with TSQuery seemed to only bring up forks of TypeScript.

https://bigtsquery.firebaseapp.com/query?selector=CallExpression%3EPropertyAccessExpression%5Bname.name%3DgetSuggestionForNonexistentProperty%5D

CallExpression>PropertyAccessExpression[name.name=getSuggestionForNonexistentExport]

@mhegazy mhegazy added Breaking Change Would introduce errors in existing code Domain: API Relates to the public API for TypeScript labels Jul 9, 2018
@mhegazy mhegazy added this to the TypeScript 3.0 milestone Jul 9, 2018
@mhegazy
Copy link
Contributor

mhegazy commented Jul 9, 2018

Please add a note about this change in https://github.com/Microsoft/TypeScript/wiki/API-Breaking-Changes

@DanielRosenwasser DanielRosenwasser merged commit 3dd1d25 into master Jul 10, 2018
@mhegazy mhegazy deleted the internalizeNonexistentHelpers branch July 10, 2018 21:18
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mhegazy mhegazy mhegazy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@DanielRosenwasser DanielRosenwasser

Labels

Breaking Change Would introduce errors in existing code Domain: API Relates to the public API for TypeScript

Projects

None yet

Milestone

TypeScript 3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@DanielRosenwasser @mhegazy