-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved handling of structurally identical classes #19671
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahejlsberg
requested review from
DanielRosenwasser,
mhegazy and
RyanCavanaugh
November 1, 2017 22:51
mhegazy
approved these changes
Nov 2, 2017
This may fix #11664 too : ) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we improve the handling of structurally identical classes in union types and
instanceof
expressions:instanceof
operator is now based on whether the type of the left operand derives from the type indicated by the right operand (as opposed to a structural subtype check).This means that union types and
instanceof
properly distinguish between structurally identical classes. For example:The comments show the places where we previously got it wrong (or, I should say, less right).
Note that this PR does not change the fact that structurally identical types are subtypes and assignment compatible. The changes are entirely confined to the
instanceof
operator and reduction of union types.The PR is technically a breaking change because we now preserve unions of structurally identical class types where we would previously reduce the union to one of the class types. Any errors resulting from this should be fixable with a type assertion or a type annotation. (There are no new errors compiling DefinitelyTyped, but a couple in the real world code suites.)
Fixes #10934.
Fixes #11965.
Fixes #14426.
Fixes #15585.
Fixes #15615.
Fixes #17612.
Fixes #18276.