TypeChecker#getConstantValue(node) doesn't properly resolve values

[DanielRosenwasser]

Courtesy of @ivogabe from here.

I'm working with the compiler api and I noticed that TypeChecker#getConstantValue(node) only returns a value if I first call TypeChecker#getSymbolAtLocation(node). node is an ElementAccessExpression or a PropertyAccessExpression. Is that a bug or by design?

[mhegazy]

We would take a PR for this.

[ivogabe]

I think I found the cause, I can try to submit a PR later today

[ivogabe]

It turns out that getConstantValue still returns undefined on enum references with bracket notation, even though I'm calling getSymbolAtLocation first. So my 'fix' isn't working for bracket access (Foo['Bar']). I've no idea how that can be fixed, so can someone else take a look at this?

[mhegazy]

@vladima can you take a look

[ivogabe]

Can someone take a look at PR #4498? Looks like that would solve my issue, but it has never been reviewed.