Skip to content

Fix few typos in user guide #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2017
Merged

Fix few typos in user guide #20

merged 1 commit into from
Mar 9, 2017

Conversation

@jozefizso
Copy link
Contributor

@jozefizso jozefizso commented Feb 27, 2017

No description provided.

@msftclas
Copy link

msftclas commented Feb 27, 2017

@jozefizso,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@yazeng
Copy link
Contributor

yazeng commented Feb 27, 2017

Can one of the admins verify this patch?

@msftgits
Copy link
Contributor

msftgits commented Feb 27, 2017

Hi, I am closing and re-opening this PR to bump the CLA bot. Sorry for the inconvenience!

@msftgits msftgits closed this Feb 27, 2017
@msftgits msftgits reopened this Feb 27, 2017
@msftclas
Copy link

msftclas commented Feb 27, 2017

@jozefizso,
Thanks for having already signed the Contribution License Agreement. Your agreement has not been validated yet. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

yazeng
yazeng reviewed Mar 2, 2017
View reviewed changes
docs/PTFUserGuide.md Outdated
__Examples__

1. Command “set ptfprop” can be used in the script to display all properties in the PTFconfig. User will get the outputs like:
1. Command “set ptfprop" can be used in the script to display all properties in the PTFconfig. User will get the outputs like:
Copy link
Contributor

@yazeng yazeng Mar 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first quotation mark should be changed too.
There're also many other places that need to replace the first quotation mark.

Copy link
Contributor Author

@jozefizso jozefizso Mar 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed the missing incorrect quotations.

@yazeng
Copy link
Contributor

yazeng commented Mar 2, 2017

Hi Jozef,
Thank you for reviewing user guide for us and find us so many typos ;)
The overall changes look good to me except one comment.

Thanks again,
Yan

@yazeng
Copy link
Contributor

yazeng commented Mar 9, 2017

Looks good to me. Thank you!!

@yazeng yazeng merged commit f0062b8 into microsoft:master Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@yazeng yazeng yazeng left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jozefizso @msftclas @yazeng @msftgits