Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid digital signature on samples and ml vsix #523

Closed
huguesv opened this issue Jun 29, 2015 · 4 comments
Closed

Invalid digital signature on samples and ml vsix #523

huguesv opened this issue Jun 29, 2015 · 4 comments
Labels
bug

Comments

@huguesv
Copy link
Contributor

huguesv commented Jun 29, 2015

PTVS 2.2 30626.00

sig
@zooba
Copy link
Member

zooba commented Jun 30, 2015

So this is because VS 2015 has stopped accepting SHA1 certificates on VSIX files, and VS 2013 doesn't accept SHA256. We'll probably have to start shipping separate VSIX files or replace this with an MSI.

What I don't understand is how you got this error with only VS 2013 installed. Had you already installed the samples into VS 2015 on that machine?

@zooba zooba added this to the 2.2 milestone Jun 30, 2015
@huguesv
Copy link
Contributor Author

huguesv commented Jun 30, 2015

Yes on that last question, that's why it wasn't in the list in the screenshot.

@zooba
Copy link
Member

zooba commented Jul 14, 2015

I tried making separate VSIX files for VS 2013 and VS 2015 and signing the latter with a SHA256 certificate, but they still appeared as invalid.

Workaround is to validate the signature using VSIXInstaller.exe from a VS 2013 installation explicitly (not by double-clicking the VSIX file).

@zooba zooba removed this from the 2.2 milestone Jul 14, 2015
@zooba zooba added the wontfix label Oct 26, 2015
@zooba
Copy link
Member

zooba commented Oct 26, 2015

This will be fixed for 3.0 when we drop VS 2013 support, but it won't be fixed any earlier than that.

@zooba zooba closed this as completed Oct 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zooba @huguesv