support max_depth option, to solve (#33) #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guolinke
changed the title
chivee
approved these changes
Oct 25, 2016
| @@ -139,6 +142,8 @@ class Tree { | |||
| int* leaf_parent_; | |||
| /*! \brief Output of leaves */ | |||
| score_t* leaf_value_; | |||
| /*! \brief Depth for leaves */ | |||
| int* leaf_depth_; | |||
There was a problem hiding this comment.
is there a need for every leaves ?
There was a problem hiding this comment.
Yes, since we don't know which leaf will be splitted ..
| @@ -163,6 +163,8 @@ class SerialTreeLearner: public TreeLearner { | |||
| double histogram_pool_size_; | |||
| /*! \brief used to cache historical histogram to speed up*/ | |||
| LRUPool<FeatureHistogram*> histogram_pool_; | |||
| /*! \brief max depth of tree model */ | |||
| int max_depth_; | |||
There was a problem hiding this comment.
i think it will be good to make max_depth as an early_stop condition
There was a problem hiding this comment.
I think early stopping is for the progress of boosting, not for tree growth..
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve #33