Skip to content

Avoid string allocations in hot path. #1004

Closed

Description

The TryGetDataSeries method in Metric class has a validation of dimension name achieving via a util class. The call to this method is quite expensive due to string allocation/conversions in Invariant() method - Invariant($"{nameof(dimensionValues)}[{d}]")

https://github.com/Microsoft/ApplicationInsights-dotnet/blob/develop/src/Microsoft.ApplicationInsights/Metric.cs#L450

Proposal is to modify code to avoid this computation unless necessary. (neccessary = dimension is invalid, which is not the common case)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions