Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

ILogger - Exception.Message is populated as ExceptionTelemetry.Message, Bump version #282

Merged
merged 6 commits into from
May 1, 2019

Conversation

cijothomas
Copy link
Contributor

@cijothomas cijothomas commented Apr 26, 2019

ILogger - If an exception is passed to log, then Exception.Message is populated as ExceptionTelemetry.Message.

If TrackExceptionsAsExceptionTelemetry is false, then Exception.Message is stored as custom property "ExceptionMessage"

Foe example, consider the following log call.
testLogger.LogError(new Exception("ExceptionMessage"), "LoggerMessage");
The ExceptionTelemetry created will contain "ExceptionMessage" in its Message field. "LoggerMessage" will be in custom property "FormattedMessage"

If TrackExceptionsAsExceptionTelemetry is false, then TraceTelemetry is created, and "LoggerMessage" will be in its Message field. "ExceptionMessage" will be in custom property "ExceptionMessage"

Prior to this, when an exception is passed to log, its Exception.Message was not stored anywhere.

Also bumped and updated versions.

@RamjotSingh
Copy link
Contributor

How does this behave when users use LogError with exception object in it? I think we might be regressing that here.

@cijothomas
Copy link
Contributor Author

@RamjotSingh i have edited to give example. (I submitted PR with empty description, sorry)

@cijothomas
Copy link
Contributor Author

/azp run

@cijothomas
Copy link
Contributor Author

/AzurePipelines run

@cijothomas cijothomas closed this Apr 26, 2019
@cijothomas cijothomas reopened this Apr 26, 2019
@cijothomas
Copy link
Contributor Author

/AzurePipelines help

@cijothomas cijothomas closed this Apr 26, 2019
@cijothomas cijothomas reopened this Apr 26, 2019
@azure-pipelines
Copy link

For the Azure DevOps organization bhyada, no matching pipelines using the Azure Pipelines app were found for this pull request.

1 similar comment
@azure-pipelines
Copy link

For the Azure DevOps organization bhyada, no matching pipelines using the Azure Pipelines app were found for this pull request.

@azure-pipelines
Copy link

Supported commands
     help:
          Get descriptions, examples and documentation about supported commands
          Example: help "command_name"
     run:
          Run all pipelines or a specific pipeline for this repository using a comment. Use
          this command by itself to trigger all related pipelines, or specify a pipeline
          to run.
          Example: "run" or "run pipeline_name"

See additional documentation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants