Adding support for disabledEventSourceNamePrefix configuration #122
Description
openedon Nov 8, 2017
Due to a .NET Framework bug: https://github.com/dotnet/coreclr/issues/14434, there's a discussion providing support for configurations to allow totally disabling some event sources by their name prefixes.
Details of the discussion could be found here: Azure/diagnostics-eventflow#140.
@SergeyKanzhelev, @dnduffy, I am planning to put the implementation into EventSourceTelemetryModule
.
Here's a simple description:
Configuration:
Details:
-
Disabling EventSources is not recommended under normal circumstances, however, due to some edge cases, like the bug here: https://github.com/dotnet/coreclr/issues/14434, there needs a way to work-around it.
-
For event-source that matches in the 'Sources' exactly and at the same time, starts with disabledEventSourceNamePrefix, the enabling of the source will take the priority because:
- Exact match should take over partial match;
- Generally, for telemetry module settings, we are using the opt-in than opt-out;
- It is flexible that user can express: I want
abc
event source but not anything else that starts withab
, because either I don't care or they are having issues.
Please use this issue for feedback on the ideas and I'll submit PR for review when it is implemented.