This repository has been archived by the owner on Jun 10, 2020. It is now read-only.
Fix TypeInitializationException for WebHostBuilder #821
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HostingDiagnosticListener uses WebHostBuilder class to determine Asp.NET Core version. Base IWebHostBuilder interface is loaded from Microsoft.AspNetCore.Hosting.Abstractions while WebHostBuilder is defined in Microsoft.AspNetCore.Hosting.
AppInsights SDK reference Ms.AspNetCore.Hosting 1.0.2.
In AspNetCore 2.0 timeframe, a new interface method
ConfigureAppConfiguration
was added to IWebHostBuilder, which 1.0.2 does not implement.If user app does reference abstractions of relevant version (2.0+), but not hosting, the base interface has
ConfigureAppConfiguration
while implementation AppInsights brings in 1.0.2 does not implement it which causes this error.This is the case in WebJobs.
This change determines AspNetCore version based on IWebHodstBuilder to avoid issues like this.
It also changes how we test HostingDiagnosticListener, allowing to parametrize aspnetcore version and test different combinations.