revert GFM list reformatting

Author: NickGeek

src/Note.ts

@@ -35,24 +35,15 @@ export type MarkdownNote = {
 };
 
 export default class Note extends NPXObject {
-	public readonly elements: NoteElement[];
-
 	constructor(
 		public readonly title: string,
 		public readonly time: number = new Date().getTime(),
-		elements: NoteElement[] = [],
+		public readonly elements: NoteElement[] = [],
 		public readonly bibliography: Source[] = [],
 		internalRef?: string,
 		parent?: Parent | string
 	) {
 		super(title, internalRef, parent);
-
-		// Fix historical GFM task list inconsistency
-		this.elements = elements.map(el =>
-			el.type === 'markdown'
-				? { ...el, content: el.content.replace(/[-*] \[\]/gm, '- [ ]') }
-				: el
-		);
 	}
 
 	public addElement(element: NoteElement): Note {
@@ -97,7 +88,7 @@ export default class Note extends NPXObject {
 		return this.elements
 			.filter(e => e.type === 'markdown')
 			.map(e => e.content.match(/(^|\s)(#[a-z\d-]+)/gi))
-			.filter(Boolean)
+			.filter(res => !!res)
 			.map(matches => Array.from(matches!))
 			.reduce((acc, val) => acc.concat(val), [])
 			.map(hashtag => hashtag.trim());

src/tests/Note.spec.ts

@@ -238,50 +238,6 @@ describe('Note', () => {
 		expect(res).toMatchSnapshot();
 	});
 
-	describe('task list compatibility', () => {
-		const expected = '- [ ] not done\n* - [ ] not done\n\t- [x] done\n* [X] also done';
-
-		it('should ignore correct GFM syntax', () => {
-			// Arrange
-			// Act
-			let note = new Note('So much to do, so little time', 0, [
-				{
-					type: 'markdown',
-					content: expected,
-					args: {
-						id: 'testmd',
-						x: '0',
-						y: '0',
-						width: 'auto'
-					}
-				}
-			]);
-
-			// Assert
-			expect(note.elements[0].content).toEqual(expected);
-		});
-
-		it('should fix incorrect GFM syntax', () => {
-			// Arrange
-			// Act
-			let note = new Note('So much to do, so little time', 0, [
-				{
-					type: 'markdown',
-					content: '- [] not done\n* - [] not done\n\t- [x] done\n* [X] also done',
-					args: {
-						id: 'testmd',
-						x: '0',
-						y: '0',
-						width: 'auto'
-					}
-				}
-			]);
-
-			// Assert
-			expect(note.elements[0].content).toEqual(expected);
-		});
-	});
-
 	describe('canOptimiseElement', () => {
 		it('should be true for image elements when not specified', () => {
 			expect(canOptimiseElement({