Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGZILLA #16426] Add support for short hexadecimal colors #5822

Open
MichaelChirico opened this issue May 18, 2020 · 2 comments
Open

[BUGZILLA #16426] Add support for short hexadecimal colors #5822

MichaelChirico opened this issue May 18, 2020 · 2 comments

Comments

@MichaelChirico
Copy link
Owner

Created attachment 1845 [details]
short hexadecimal colors

Hello everybody, I'm new in R and here.

This diff adds the support for short hexadecimal colors. So:

plot(x, col='#ABC')

will be the same as:

plot(x, col='#AABBCC')

I think it's a convenient shortcut. What do you think?

--
Xavier Nayrac


METADATA

  • Bug author - xavier nayrac
  • Creation time - 2015-06-15 15:26:29 UTC
  • Bugzilla link
  • Status - UNCONFIRMED
  • Alias - None
  • Component - Wishlist
  • Version - R-devel (trunk)
  • Hardware - x86_64/x64/amd64 (64-bit) Linux-Debian
  • Importance - P5 enhancement
  • Assignee - R-core
  • URL -
  • Modification time - 2015-07-01 09:23 UTC
@MichaelChirico
Copy link
Owner Author

Comment on attachment 1845 [details]
short hexadecimal colors

These shorthand color specs are used in CSS. I don't see this as a high priority, but I'd consider a patch to implement it. Your current patch has some problems though:

  • You should use "svn diff" to produce the patch, so we know which version of which files you've used
  • You shouldn't edit the whitespace in the files, or make other changes unrelated to the change.
  • You need to update the documentation as well. I expect you'll need to edit the help pages for par() and col2rgb() and possibly others.

METADATA

  • Comment author - Duncan Murdoch
  • Timestamp - 2015-06-22 11:17:34 UTC

INCLUDED PATCH

@MichaelChirico
Copy link
Owner Author

It's cleary low priority.

  • I'll use svn for the patch.
  • I'll remove unrelated changes. But I am just curious: when and how do you improve the code, i.e do you make a patch just for whitespaces, newlines, etc?
  • I'll update the documentation as well.

Thank you for the feedback ;)


METADATA

  • Comment author - xavier nayrac
  • Timestamp - 2015-07-01 09:23:48 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant