Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider en@quot on Windows #258

Open
hadley opened this issue Nov 8, 2021 · 1 comment
Open

Consider en@quot on Windows #258

hadley opened this issue Nov 8, 2021 · 1 comment

Comments

@hadley
Copy link
Collaborator

hadley commented Nov 8, 2021

Continuing from discussion from #234 (comment)

The source claims it's only run in UTF8 locale because "substr()" needs to count UTF-8:
https://github.com/wch/r-source/blob/430360aa394b02046dd7175c0fc55e347e947f80/src/library/tools/R/translations.R#L21-L22. But I don't think that's true any longer (as long as the encoding of the string is correct), so I think it's worth trying to run unconditionally, and if that doesn't work, providing a version of en_quote() that does work.
@MichaelChirico
Copy link
Owner

Happy to try! If it works, that should be reflected back to r-devel as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hadley @MichaelChirico