@@ -808,7 +808,7 @@ def test_regr_funcs_sql(df):
808808
809809 assert result [0 ].column (0 ) == pa .array ([None ], type = pa .float64 ())
810810 assert result [0 ].column (1 ) == pa .array ([None ], type = pa .float64 ())
811- assert result [0 ].column (2 ) == pa .array ([1 ], type = pa .float64 ())
811+ assert result [0 ].column (2 ) == pa .array ([1 ], type = pa .uint64 ())
812812 assert result [0 ].column (3 ) == pa .array ([None ], type = pa .float64 ())
813813 assert result [0 ].column (4 ) == pa .array ([1 ], type = pa .float64 ())
814814 assert result [0 ].column (5 ) == pa .array ([1 ], type = pa .float64 ())
@@ -840,7 +840,7 @@ def test_regr_funcs_sql_2():
840840 # Assertions for SQL results
841841 assert result_sql [0 ].column (0 ) == pa .array ([2 ], type = pa .float64 ())
842842 assert result_sql [0 ].column (1 ) == pa .array ([0 ], type = pa .float64 ())
843- assert result_sql [0 ].column (2 ) == pa .array ([3 ], type = pa .float64 ()) # todo: i would not expect this to be float
843+ assert result_sql [0 ].column (2 ) == pa .array ([3 ], type = pa .uint64 ())
844844 assert result_sql [0 ].column (3 ) == pa .array ([1 ], type = pa .float64 ())
845845 assert result_sql [0 ].column (4 ) == pa .array ([2 ], type = pa .float64 ())
846846 assert result_sql [0 ].column (5 ) == pa .array ([4 ], type = pa .float64 ())
@@ -852,7 +852,7 @@ def test_regr_funcs_sql_2():
852852@pytest .mark .parametrize ("func, expected" , [
853853 pytest .param (f .regr_slope , pa .array ([2 ], type = pa .float64 ()), id = "regr_slope" ),
854854 pytest .param (f .regr_intercept , pa .array ([0 ], type = pa .float64 ()), id = "regr_intercept" ),
855- pytest .param (f .regr_count , pa .array ([3 ], type = pa .float64 ()), id = "regr_count" ), # TODO: I would expect this to return an int array
855+ pytest .param (f .regr_count , pa .array ([3 ], type = pa .uint64 ()), id = "regr_count" ),
856856 pytest .param (f .regr_r2 , pa .array ([1 ], type = pa .float64 ()), id = "regr_r2" ),
857857 pytest .param (f .regr_avgx , pa .array ([2 ], type = pa .float64 ()), id = "regr_avgx" ),
858858 pytest .param (f .regr_avgy , pa .array ([4 ], type = pa .float64 ()), id = "regr_avgy" ),
0 commit comments