Skip to content

Commit df13f3c

Browse files
fatherMatrixgregkh
authored andcommitted
mm: optimize the redundant loop of mm_update_owner_next()
commit cf3f9a5 upstream. When mm_update_owner_next() is racing with swapoff (try_to_unuse()) or /proc or ptrace or page migration (get_task_mm()), it is impossible to find an appropriate task_struct in the loop whose mm_struct is the same as the target mm_struct. If the above race condition is combined with the stress-ng-zombie and stress-ng-dup tests, such a long loop can easily cause a Hard Lockup in write_lock_irq() for tasklist_lock. Recognize this situation in advance and exit early. Link: https://lkml.kernel.org/r/20240620122123.3877432-1-alexjlzheng@tencent.com Signed-off-by: Jinliang Zheng <alexjlzheng@tencent.com> Acked-by: Michal Hocko <mhocko@suse.com> Cc: Christian Brauner <brauner@kernel.org> Cc: Jens Axboe <axboe@kernel.dk> Cc: Mateusz Guzik <mjguzik@gmail.com> Cc: Matthew Wilcox (Oracle) <willy@infradead.org> Cc: Oleg Nesterov <oleg@redhat.com> Cc: Tycho Andersen <tandersen@netflix.com> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent b11e8fb commit df13f3c

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

kernel/exit.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -432,6 +432,8 @@ void mm_update_next_owner(struct mm_struct *mm)
432432
* Search through everything else, we should not get here often.
433433
*/
434434
for_each_process(g) {
435+
if (atomic_read(&mm->mm_users) <= 1)
436+
break;
435437
if (g->flags & PF_KTHREAD)
436438
continue;
437439
for_each_thread(g, c) {

0 commit comments

Comments
 (0)