Skip to content

DietPi-Software | Beets#4438

Merged
MichaIng merged 22 commits into
devfrom
beets
Jun 16, 2021
Merged

DietPi-Software | Beets#4438
MichaIng merged 22 commits into
devfrom
beets

Conversation

@nonnorm
Copy link
Copy Markdown
Collaborator

@nonnorm nonnorm commented May 29, 2021

Status: Ready

Reference: #4434

Commit list/description:

  • DietPi-Software | Add Beets installation option

+ DietPi-Software | Add Beets installation option
@nonnorm nonnorm added this to the v7.3 milestone May 29, 2021
@nonnorm nonnorm self-assigned this May 29, 2021
@nonnorm nonnorm linked an issue May 29, 2021 that may be closed by this pull request
nonnorm added 5 commits May 29, 2021 16:12
+ DietPi-Software | Fix capitalization
+ DietPi-Software | Remove bashrc.d file
+ DietPI-Software | Source beets bashrc.d file
+ DietPi-Software | Fix G_EXEC typo
+ DietPi-Software | Add shebang to beets bashrc.d script
@nonnorm nonnorm requested review from Joulinar and MichaIng May 29, 2021 21:32
nonnorm and others added 8 commits May 29, 2021 16:33
+ DietPi-Software | Add Beets installation option
+ DietPi-Software | Fix capitalization
+ DietPi-Software | Remove bashrc.d file
+ DietPI-Software | Source beets bashrc.d file
+ DietPi-Software | Fix G_EXEC typo
+ DietPi-Software | Add shebang to beets bashrc.d script
META | Update beets branch
Comment thread dietpi/dietpi-software Outdated
Comment thread dietpi/dietpi-software Outdated
Comment thread dietpi/dietpi-software Outdated
Comment thread dietpi/dietpi-software Outdated
nonnorm and others added 3 commits June 16, 2021 13:25
+ DietPi-Software | Fixes
+ DietPi-Software | Beets: Merge install and config blocks, as both as very small and we anyway want to merge them for all software titles soon
+ DietPi-Software | Beets: Apply switch to /mnt/dietpi_userdata/beets for all steps
+ DietPi-Software | Beets: Limit write access to library to dietpi user and members of audio group
+ Typo
MichaIng
MichaIng previously approved these changes Jun 16, 2021
+ DietPi-Software | Beets: Pre-create state file as well and apply group write permissions to whole directory. Somehow managing the library does not work when beets dir write permissions are granted, despite the fact that no file needs to be created or removed (?).
@MichaIng
Copy link
Copy Markdown
Owner

A little too geeky for me, to manage a music library from the command line like this, but it works fine.

I changed permissions the way that the library and state files are pre-created with access limited to dietpi user and audio group members. Otherwise, the first user that imports/updates the library will have them blocked with 644 mode for everyone else. Not a big issue, but the way it is now it's a little more defined. The audio files are still created with default mode of course, but no change to do something about that.

MichaIng
MichaIng previously approved these changes Jun 16, 2021
@nonnorm
Copy link
Copy Markdown
Collaborator Author

nonnorm commented Jun 16, 2021

Personally I like it because it lets you organize and import music for other apps that don't have an inbuilt music organizer, but will display it using those attributes.

@MichaIng
Copy link
Copy Markdown
Owner

Jep, I definitely see the use case. For things like this I personally prefer a GUI, but it's great to have a CLI solution in our portfolio 🙂.

@MichaIng
Copy link
Copy Markdown
Owner

I also just read a bit through the docs and see all the plugins, e.g. to trigger an MPD or Kodi database update automatically, import from IPFS, generate playlists etc etc: https://beets.readthedocs.io/en/stable/plugins/
So it is able to integrate very fine with many other media software, making it quite mighty 👍.

+ README | Add Beets to 3rd party sources list
MichaIng added 2 commits June 17, 2021 00:25
+ CHANGELOG | Beets: This command line music organizer and manager has been added with software ID 190.
MichaIng
MichaIng previously approved these changes Jun 16, 2021
@MichaIng
Copy link
Copy Markdown
Owner

LGTM. Ready to be merged from your end?

@nonnorm
Copy link
Copy Markdown
Collaborator Author

nonnorm commented Jun 16, 2021

Yep.

@MichaIng MichaIng merged commit d3cc283 into dev Jun 16, 2021
@MichaIng MichaIng deleted the beets branch June 16, 2021 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DietPi-Software | Beets

2 participants