Powershell 5 compatibility for Build-Module.ps1 #496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Told you so :) |
3 tasks
Contributor
|
I can only merge when the test do not fail. |
Contributor
Author
|
Builds now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Encoding
UTF8BOMfor Set-Content was not available is PS5. This PR makes the encoding value conditional.The readme states the lower bound of Powershell compatibility at 5.
The only way to test that is to introduce an explicitly PS5 build in the CI scripts. That's a maintainer level decision.
The CI will fail over the Update-VSTeamProject autotest issue. Only merge when/if either #494 or #495 lands.
PR Checklist