Skip to content

Conversation

@rbleattler
Copy link
Contributor

PR Summary

PR Checklist

Bleattler and others added 5 commits August 16, 2022 11:15
… the default branch of a repository.

- Fixed bad link in README.md
…ze it as something when mocked)

Removed call to dot source common.ps1
Removed debug messages
Cleaned up comments
Bumped Version
Updated Changelog
fix: Remove space in -Build paramter of example 4 (MethodsAndPractices#472)
@rbleattler
Copy link
Contributor Author

@SebastianSchuetze do I need to re-submit with SupportsShouldProcess implemented?

@SebastianSchuetze
Copy link
Contributor

What do you mean resubmit? You can just keep editing your branch until everything is fine. You didn't need to close the PR and reopen one.

Just commit here until everything is fine. At the end we do a squash merge anyways.

@rbleattler
Copy link
Contributor Author

Thanks, I learn something new every day. I'll try to get this updated on Monday.

Bleattler added 3 commits August 22, 2022 11:47
- Added logic to pull refs and validate branch name
- Updated call to use splatting for readability
- Added test for non-existent branch name
@rbleattler
Copy link
Contributor Author

I believe everything that needed to be fixed has been fixed, including adding support for SupportsShouldProcess / -WhatIf

@SebastianSchuetze
Copy link
Contributor

I removed some lines in the changelog because it is not interesting if there are typo changes. Only real changes for somebody using the modules is interesting. E.g. bug fixes or new features in cmdlets or the documentation of the cmdlets themselve.

approved and merged. Thanks very much!!

@SebastianSchuetze SebastianSchuetze merged commit 6e899cc into MethodsAndPractices:trunk Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants