Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate IAttribute::modelSaved()? #1178

Open
richardhj opened this issue Aug 29, 2017 · 2 comments
Open

Deprecate IAttribute::modelSaved()? #1178

richardhj opened this issue Aug 29, 2017 · 2 comments
Assignees
Labels
enhancement This issue is about an enhancement (aka new feature)
Milestone

Comments

@richardhj
Copy link
Member

The modelSaved method is not called reliable, i.e. as for the alias generation (see comments 1-3 at MetaModels/contao-frontend-editing#6).

We can
a) deprecate the modelSaved() and switch to the pre-persist event of the DCG. Problem: The event has no knowledge of its prior value, and an alias value might be overwritten even if already present in the database.
b) pass the up-to-date data to the modelSaved(). Problem: more time costs at runtime

(@discordier feel free to edit this post)

@zonky2 zonky2 added the enhancement This issue is about an enhancement (aka new feature) label Aug 30, 2017
@zonky2 zonky2 added this to the 2.0.0 milestone Aug 30, 2017
@discordier
Copy link
Member

We must re-evaluate if the event will solve the problem, as it might not work anymore as dcg now clears values depending on extra "alwaysSave" etc.

@zonky2 zonky2 modified the milestones: 2.0.0, 2.1.0, 2.2.0 Mar 9, 2018
@zonky2 zonky2 modified the milestones: 2.2.0, 2.3.0 May 5, 2022
@zonky2
Copy link
Contributor

zonky2 commented Aug 23, 2022

@discordier is this obsolete? the attribute alias works fine at FEE

@zonky2 zonky2 modified the milestones: 2.3.0, 2.4.0 Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue is about an enhancement (aka new feature)
Projects
None yet
Development

No branches or pull requests

5 participants