Some fixes

- Clean up duplicate entries in yaml configs
- Refactor deep-copy: use prepared statements and bind values for inserts

Author: stefanheimes

src/EventListener/BackendEventListener.php

@@ -146,11 +146,18 @@ private function duplicateContentEntries($strTable, $intSourceId, $intDestinatio
             $arrContent['pid'] = $intDestinationId;
             unset($arrContent['id']);
 
+            $parameters = [];
+            foreach (array_keys($arrContent) as $key) {
+                $parameters[$key] = '?';
+            }
+
             $this->connection
                 ->createQueryBuilder()
                 ->insert('tl_content')
-                ->setParameters($arrContent)
-                ->executeQuery();
+                ->values($parameters)
+                ->setParameters(array_values($arrContent))
+                ->executeStatement()
+            ;
         }
     }
 

src/Resources/config/listeners.yml

@@ -1,6 +1,8 @@
 services:
   MetaModels\AttributeTranslatedContentArticleBundle\EventListener\BackendEventListener:
     public: false
+    arguments:
+      - '@database_connection'
     tags:
       - name: kernel.event_listener,
         event: 'dc-general.view.contao2backend.manipulate-widget'

src/Resources/config/services.yml

@@ -6,10 +6,5 @@ services:
     tags:
       - { name: metamodels.attribute_factory }
 
-  MetaModels\AttributeTranslatedContentArticleBundle\EventListener\BackendEventListener:
-    public: true
-    arguments:
-      - '@database_connection'
-
   MetaModels\AttributeTranslatedContentArticleBundle\Controller\Backend\MetaModelController:
     tags: ['controller.service_arguments']