deps: @metamask/rpc-errors@^6.3.1->^7.0.0 #2817
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@metamask/rpc-errorsfrom^6.3.1to^7.0.0shouldPreserveMessagetofalsefor all invocations ofserializeErrorOpen question
Currently
snaps-rpc-methodstests fail because some errors now have the new (old) behavior of not wrapping error messages.Haven't figured out if there is something else at play as well/instead but looks like at least
@metamask/json-rpc-enginecallsserializeErrorwith default arguments which are not currently overridable (though that dependency is still on v6 so TBD)If the above is correct, which of these options are preferred?
JsonRpcEngineto allow overridingserializeErroroptionssnaps-rpc-methodsto accomodate to new defaultsRelated
@metamask/snaps-sdk?