Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format snap.manifest.json with Prettier #786

Closed
Mrtenz opened this issue Sep 27, 2022 · 0 comments · Fixed by #2787
Closed

Format snap.manifest.json with Prettier #786

Mrtenz opened this issue Sep 27, 2022 · 0 comments · Fixed by #2787
Labels
type-enhancement New feature or request

Comments

@Mrtenz
Copy link
Member

Mrtenz commented Sep 27, 2022

Right now we take the output from JSON.stringify and put it in the snap.manifest.json. This results in issues as described in MetaMask/test-snaps#71. As a solution, we could format the manifests with Prettier before writing to the disk.

Prettier has a nice API, so it's essentially just a case of calling prettier.format(config, options). For the options, we could default to the user's .prettierrc, and use Prettier's defaults otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants