fix: Download file requested when connecting to any Dapp #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous JS injection was catching a Blob file creation and triggered downloading immediately. Turned out some Dapps may create Blob files without user actually trying to download these files. To prevent the issue, we try to download Blobs only on clicks on download elements in the website or when Android receives a download callback
sethkfman
reviewed
Jun 24, 2025
package.json
Outdated
| @@ -10,7 +10,7 @@ | |||
| "Thibault Malbranche <malbranche.thibault@gmail.com>" | |||
| ], | |||
| "license": "MIT", | |||
| "version": "14.2.0", | |||
| "version": "14.2.1", | |||
There was a problem hiding this comment.
Let's bump the version in a separate release PR.
There was a problem hiding this comment.
Sure. Downgraded back to 14.2.0
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue in the tracker: MetaMask/metamask-mobile#16528
Previous JS injection was catching a Blob file creation and triggered downloading immediately. Turned out some Dapps may create Blob files without user actually trying to download these files. To prevent the issue, we try to download Blobs only on clicks on download elements in the website or when Android receives a download callback.
To test Blob file downloading I use two websites:
https://eligrey.com/demos/FileSaver.js/
https://tyschenko.github.io/download_blob_file.html
Screenshot of the problem in Uniswap.org Dapp:
Video of the solution showing downloading of Blob files and opening of Uniswap.org and pancakeswap.finance Dapps:
https://github.com/user-attachments/assets/991b9a3b-a9f6-4c72-b25f-1133832ef1f0