Add URL information about geolocation user info request #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is how it will look now |
joaoloureirop
requested changes
Oct 7, 2024
android/src/main/java/com/reactnativecommunity/webview/RNCWebChromeClient.java
Outdated
Show resolved
Hide resolved
|
follow-up after full url discussion https://github.com/MetaMask/mobile-planning/issues/1923#issuecomment-2396933239 |
…hromeClient.java Co-authored-by: João Loureiro <175489935+joaoloureirop@users.noreply.github.com> Signed-off-by: Kylan Hurt <kylanhurt@users.noreply.github.com>
joaoloureirop
requested changes
Oct 8, 2024
| @@ -40,6 +40,7 @@ | |||
| import java.util.ArrayList; | |||
| import java.util.Collections; | |||
| import java.util.List; | |||
| import java.net.URI; | |||
| @@ -232,7 +233,6 @@ private void runDelayed(Runnable function, long delayMillis) { | |||
|
|
|||
| @Override | |||
| public void onGeolocationPermissionsShowPrompt(String origin, GeolocationPermissions.Callback callback) { | |||
|
|
|||
android/src/main/java/com/reactnativecommunity/webview/RNCWebChromeClient.java
Outdated
Show resolved
Hide resolved
Co-authored-by: João Loureiro <175489935+joaoloureirop@users.noreply.github.com> Signed-off-by: Kylan Hurt <kylanhurt@users.noreply.github.com>
|
Ah, github suggested changes messed up with the code indentation. |
joaoloureirop
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/MetaMask/mobile-planning/issues/1923