Skip to content

Conversation

@OGPoyraz
Copy link
Member

Description

This PR aims to hide testnet fiat values if user opt out in the settings.

Open in GitHub Codespaces

Related issues

Manual testing steps

  1. Change current network to any testnet
  2. Go to setting, turn on "Show conversion on test networks"
  3. Try simple send - see fiat values displayed in simulations
  4. Go to setting, turn off "Show conversion on test networks"
  5. Try simple send - see no fiat values displayed in simulations
  6. Change current network to mainnet or any other network which is not testnet
  7. Try simple send - see fiat values displayed in simulations

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz linked an issue Jun 10, 2024 that may be closed by this pull request
@OGPoyraz OGPoyraz requested a review from a team as a code owner June 10, 2024 12:33
@OGPoyraz OGPoyraz added the team-confirmations Push issues to confirmations team label Jun 10, 2024
@sonarqubecloud
Copy link

@OGPoyraz OGPoyraz merged commit 08a7949 into main Jun 20, 2024
@OGPoyraz OGPoyraz deleted the 9906-hide-amount-in-simulations-for-testnets-if-its-opted-out-by-user branch June 20, 2024 16:51
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2024
@metamaskbot metamaskbot added the release-7.27.0 Issue or pull request that will be included in release 7.27.0 label Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.27.0 Issue or pull request that will be included in release 7.27.0 team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hide amount in simulations for testnets if it's opted out by user

4 participants