Skip to content

feat(identity): link metametrics event library and replace magic strings #16807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fabiobozzo
Copy link
Contributor

Description

This PR updates the mobile app to use the new MetaMetrics library from the profile-sync-controller core package, whose purpose is to get rid of magic strings in trackEvent calls and ensure consistency across clients.

Related issues

N/A

From Jira: https://consensyssoftware.atlassian.net/browse/IDENTITY-142

Manual testing steps

  1. Build and run the mobile app
  2. Verify that Backup & Sync functionality still works correctly
  3. Check that MetaMetrics events are still being tracked properly

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@fabiobozzo fabiobozzo requested a review from a team as a code owner June 30, 2025 16:13
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@fabiobozzo fabiobozzo added the Run Smoke E2E Requires smoke E2E testing label Jun 30, 2025
Copy link
Contributor

github-actions bot commented Jun 30, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0214774
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b498a24d-91ec-4ac1-a39e-63b524503775

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​profile-sync-controller@​18.0.0 ⏵ 19.0.0-preview-f9a5dd05100 +4100100 +15100 +1100

View full report

Copy link

@fabiobozzo fabiobozzo added the No QA Needed Apply this label when your PR does not need any QA effort. label Jul 1, 2025
@fabiobozzo fabiobozzo marked this pull request as draft July 1, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Requires smoke E2E testing team-identity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants