-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: Add support for gas fees component for batch transactions #16367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
33d5f81
to
3646fc8
Compare
b368cd4
to
004f47c
Compare
b580dc9
to
7178f66
Compare
7178f66
to
4bef71a
Compare
OGPoyraz
requested changes
Jun 20, 2025
...Views/confirmations/components/rows/transactions/gas-fee-details-row/gas-fee-details-row.tsx
Outdated
Show resolved
Hide resolved
app/components/Views/confirmations/hooks/gas/useFeeCalculations.ts
Outdated
Show resolved
Hide resolved
app/components/Views/confirmations/hooks/gas/feeCalculationsShared.ts
Outdated
Show resolved
Hide resolved
app/components/Views/confirmations/hooks/gas/useFeeCalculationsTransactionBatch.ts
Show resolved
Hide resolved
app/components/Views/confirmations/hooks/transactions/useSupportsEIP1559.ts
Outdated
Show resolved
Hide resolved
app/components/Views/confirmations/hooks/transactions/useTransactionBatchSupportsEIP1559.ts
Show resolved
Hide resolved
vinistevam
reviewed
Jun 20, 2025
app/components/Views/confirmations/hooks/gas/useFeeCalculations.ts
Outdated
Show resolved
Hide resolved
vinistevam
reviewed
Jun 20, 2025
app/components/Views/confirmations/hooks/gas/useFeeCalculationsTransactionBatch.ts
Outdated
Show resolved
Hide resolved
d94d88c
to
4ec4070
Compare
4ec4070
to
c952f4e
Compare
|
OGPoyraz
approved these changes
Jun 23, 2025
vinistevam
approved these changes
Jun 23, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
No E2E Smoke Needed
If the PR does not need E2E smoke test run
No QA Needed
Apply this label when your PR does not need any QA effort.
release-7.51.0
Issue or pull request that will be included in release 7.51.0
team-confirmations
Push issues to confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5165
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist