Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Type fixes and optimizations for EngineService, Redux store #12509

Merged
merged 10 commits into from
Jan 27, 2025
Merged

fix: Type fixes and optimizations for EngineService, Redux store #12509

merged 10 commits into from
Jan 27, 2025
+33 −150

Conversation

MajorLift
Copy link
Contributor

@MajorLift MajorLift commented Dec 2, 2024 •
edited
Loading

Description

  • Define types: ReduxStore, ReduxState (superseded by chore: Chore/12435 mvp handle engine does not exist #12538)
  • Fix any types in EngineService.
  • Optimize EngineService event subscriptions:
    • Fix update_bg_state_cb callback being re-defined on every iteration.
    • Consolidate stateChange events collections into BACKGROUND_STATE_CHANGE_EVENT_NAMES constant for maintainability.

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@MajorLift MajorLift added type-tech-debt Technical debt team-tiger Tiger team (for tech debt reduction + performance improvements) labels Dec 2, 2024
@MajorLift MajorLift self-assigned this Dec 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@MajorLift MajorLift added the Run Smoke E2E Triggers smoke e2e on Bitrise label Dec 2, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@MajorLift MajorLift force-pushed the jongsun/fix/EngineService/241202-fix-EngineService-types branch from 3ade7e5 to 9cfb8f5 Compare December 2, 2024 17:54
@MajorLift MajorLift added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 2, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@MajorLift MajorLift force-pushed the jongsun/fix/EngineService/241202-fix-EngineService-types branch from abe850b to 61588b4 Compare December 2, 2024 18:41
@MajorLift MajorLift changed the base branch from main to jongsun/fix-composable-controller December 2, 2024 18:42
@MajorLift MajorLift added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 2, 2024
@github-actions GitHub Actions

This comment was marked as duplicate.

Sign in to view
@MajorLift MajorLift force-pushed the jongsun/fix/EngineService/241202-fix-EngineService-types branch from 61588b4 to d0523b0 Compare December 2, 2024 18:45
@MajorLift MajorLift added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 2, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@MajorLift MajorLift changed the title fix: EngineService types fix(types): EngineService, Redux store Dec 2, 2024
@MajorLift MajorLift added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 3, 2024
@MajorLift MajorLift force-pushed the jongsun/fix/EngineService/241202-fix-EngineService-types branch from d0523b0 to fa4ea81 Compare December 3, 2024 08:52
@MajorLift MajorLift force-pushed the jongsun/fix-composable-controller branch from d484693 to d28dd1f Compare December 3, 2024 09:04
@MajorLift MajorLift force-pushed the jongsun/fix/EngineService/241202-fix-EngineService-types branch from fa4ea81 to ff2ee98 Compare December 3, 2024 09:08
@MajorLift MajorLift changed the title fix(types): EngineService, Redux store fix(types): Define ReduxStore, ReduxState, and fix any types in EngineService Dec 3, 2024
@MajorLift MajorLift changed the title fix(types): Define ReduxStore, ReduxState, and fix any types in EngineService fix: Define types ReduxStore, ReduxState, optimize EngineService event subscriptions, fix any types in EngineService Dec 3, 2024
@MajorLift MajorLift added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 3, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@MajorLift MajorLift added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 10, 2024
@MajorLift MajorLift marked this pull request as draft January 14, 2025 10:55
auto-merge was automatically disabled January 14, 2025 10:55

Pull request was converted to draft

@MajorLift MajorLift added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 14, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 14, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: aae1af8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1a278bfd-db41-4996-a34f-e56e4d4b1086

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@MajorLift MajorLift marked this pull request as ready for review January 21, 2025 10:50
@MajorLift MajorLift enabled auto-merge January 21, 2025 14:48
@MajorLift MajorLift requested a review from Cal-L January 21, 2025 15:27
@MajorLift MajorLift added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 24, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 24, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7730e44
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a1b3d578-5836-452c-9251-c30578c1485d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@MajorLift MajorLift added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 24, 2025
Cal-L
Cal-L approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MajorLift MajorLift added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit 4aaac02 Jan 27, 2025
47 checks passed
@MajorLift MajorLift deleted the jongsun/fix/EngineService/241202-fix-EngineService-types branch January 27, 2025 17:01
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2025
@metamaskbot metamaskbot added the release-7.40.0 Issue or pull request that will be included in release 7.40.0 label Jan 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees

@MajorLift MajorLift

Labels
release-7.40.0 Issue or pull request that will be included in release 7.40.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform team-tiger Tiger team (for tech debt reduction + performance improvements) type-tech-debt Technical debt
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MajorLift @Cal-L @metamaskbot