-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add staked ETH to metamask mobile homepage and account list menu #12146
feat: add staked ETH to metamask mobile homepage and account list menu #12146
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
I have read the CLA Document and I hereby sign the CLA |
Bitrise✅✅✅ Commit hash: a1ffc42 Note
|
8718ffb
to
e3d4b1f
Compare
Bitrise❌❌❌ Commit hash: e3d4b1f Note
Tip
|
e3d4b1f
to
b1b16c7
Compare
Bitrise❌❌❌ Commit hash: b1b16c7 Note
Tip
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments but otherwise LGTM!
37f91d9
to
16c6e6f
Compare
Bitrise🔄🔄🔄 Commit hash: 16c6e6f Note
|
Bitrise✅✅✅ Commit hash: 46615fc Note
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
We want to be able to view the Staked Ethereum balance on the homepage and have the balance totals update to reflect this
This PR adds the ability for the metamask-mobile app to view the Staked Ethereum asset balance in the mobile homepage in the Token List while linking to the ETH Asset Detail view. It also adds Staked Ethereum to the homepage total balance and the Account List menu total balances as well. The functionality is gated behind the
MM_POOLED_STAKING_UI_ENABLED
flag.Related issues
Closes: https://consensyssoftware.atlassian.net/browse/STAKE-817
Manual testing steps
MM_POOLED_STAKING_UI_ENABLED="true"
injs.env
Staked Ethereum
asset balance for selected account in the homepage even if the balance is 0Screenshots/Recordings
Before
WIP
After
Pre-merge author checklist
Pre-merge reviewer checklist