Skip to content

Conversation

@jpuri
Copy link
Contributor

@jpuri jpuri commented Oct 9, 2024

Description

Add account and network section to re-designed confirmation pages.

Related issues

Fixes: #11680

Manual testing steps

  1. Enable re-designs locally
  2. Go to test dapp
  3. Submit personal sign and check page

Screenshots/Recordings

Screen.Recording.2024-10-09.at.10.26.17.AM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Oct 9, 2024
@jpuri jpuri requested a review from a team as a code owner October 9, 2024 04:50
@jpuri jpuri requested a review from a team October 9, 2024 04:50
@jpuri jpuri requested a review from a team as a code owner October 9, 2024 04:50
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri force-pushed the acc_network_info branch from 97bb4ad to d3b6c65 Compare October 9, 2024 05:48
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8193218
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4d5e5644-5861-4684-bd05-b2c9fa0ee7ba

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2024

@jpuri jpuri added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit 305f930 Oct 9, 2024
45 of 46 checks passed
@jpuri jpuri deleted the acc_network_info branch October 9, 2024 10:08
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.34.0 team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add expandable account section on personal sign page

4 participants