test: e2e fixes for #10441

[MajorLift]

Description

A large number of e2e tests are failing on #10441, and most of them do not seem directly related to the changes in the PR.

To avoid polluting the diffs in the original PR, e2e fixes will be staged and tested here, before being merged into the original once both prs have received final approvals.

Related issues

• Extracted from chore(deps): Bump @metamask/composable-controller from ^3.0.0 to ^10.0.0 #10441

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 3638195
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1186129c-d86f-4e68-a05e-f88378c8e348

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4f39501
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/144ccc9e-dab8-47d7-926b-215b966e8386

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 52.63158% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (jongsun/fix-composable-controller@4ba9792). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
app/selectors/snaps/snapController.ts	42.85%	4 Missing ⚠️
app/store/persistConfig.ts	0.00%	3 Missing ⚠️
app/reducers/swaps/index.js	0.00%	2 Missing ⚠️

Additional details and impacted files

@@                         Coverage Diff                          @@
##             jongsun/fix-composable-controller   #11162   +/-   ##
====================================================================
  Coverage                                     ?   55.30%           
====================================================================
  Files                                        ?     1564           
  Lines                                        ?    37222           
  Branches                                     ?     4421           
====================================================================
  Hits                                         ?    20587           
  Misses                                       ?    16162           
  Partials                                     ?      473           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e157ce1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/02132c91-fbeb-4c57-96fc-61711d603459

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request